From 88e0414246641efcfd4622df4d8e302ea3ef3bae Mon Sep 17 00:00:00 2001 From: Willem Kaufmann Date: Tue, 18 Feb 2025 20:53:16 -0500 Subject: [PATCH] `rptest`: use `RedpandaVersionTriple` in `java_compression_test.py` The PR https://github.com/redpanda-data/redpanda/pull/25092 is being backported to `v24.3` (see https://github.com/redpanda-data/redpanda/issues/25108). Using a `RedpandaVersionLine` of `((24, 3))` will result in the latest available version being used in the ducktape test in the future, and the upgrade test expectation is that we should be using a version without the fix, which will fail with snappy compression, before upgrading and succeeding. Change the `pre_big_endian_snappy_fix_version` variable to use the value `RedpandaVersionTriple((24, 3, 5))` to ensure we are using the correct version pre `snappy` fix. --- tests/rptest/tests/compatibility/java_compression_test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/rptest/tests/compatibility/java_compression_test.py b/tests/rptest/tests/compatibility/java_compression_test.py index 304f372e34e82..c381588b34c86 100644 --- a/tests/rptest/tests/compatibility/java_compression_test.py +++ b/tests/rptest/tests/compatibility/java_compression_test.py @@ -17,7 +17,7 @@ from ducktape.utils.util import wait_until from rptest.clients.types import TopicSpec from rptest.services.redpanda import MetricsEndpoint -from rptest.services.redpanda_installer import RedpandaVersionLine, InstallOptions, RedpandaInstaller +from rptest.services.redpanda_installer import RedpandaVersionTriple, InstallOptions, RedpandaInstaller from rptest.util import expect_exception @@ -141,7 +141,7 @@ def test_upgrade_java_compression(self, compression_type): https://github.com/redpanda-data/redpanda/issues/25091), but this test is parameterized with all compression types for completion's sake. """ - pre_big_endian_snappy_fix_version = RedpandaVersionLine((24, 3)) + pre_big_endian_snappy_fix_version = RedpandaVersionTriple((24, 3, 5)) self.start_redpanda(num_nodes=1, install_opts=InstallOptions( version=pre_big_endian_snappy_fix_version))