From a0dafd5b0a3c6af089ed84c0a6cb9ea9a508b6fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gell=C3=A9rt=20Peresztegi-Nagy?= Date: Mon, 12 Aug 2024 17:52:28 +0100 Subject: [PATCH] fix algorithm header include The file is using `std::find_if` without specifying the `algorithm` include. It has probably transitively included it previously. Without it, the redpanda open source build fails with the following: ``` /var/lib/buildkite-agent/builds/buildkite-amd64-builders-i-02d9cb4eee45a1cf5-1/redpanda/redpanda/build/release-ci/_deps/avro-src/lang/c++/impl/Node.cc:112:73: error: no member named 'find_if' in namespace 'std'; did you mean 'std::ranges::find_if'? 112 | if (!ns_.empty() && (ns_[0] == '.' || ns_[ns_.size() - 1] == '.' || std::find_if(ns_.begin(), ns_.end(), invalidChar1) != ns_.end())) { | ^~~~~~~~~~~~ | std::ranges::find_if ``` --- lang/c++/impl/Node.cc | 1 + lang/c++/impl/parsing/Symbol.hh | 1 + 2 files changed, 2 insertions(+) diff --git a/lang/c++/impl/Node.cc b/lang/c++/impl/Node.cc index b28e0915cf8..3d9d741001f 100644 --- a/lang/c++/impl/Node.cc +++ b/lang/c++/impl/Node.cc @@ -16,6 +16,7 @@ * limitations under the License. */ +#include #include #include diff --git a/lang/c++/impl/parsing/Symbol.hh b/lang/c++/impl/parsing/Symbol.hh index c8760c34dfa..bbba58e6a0e 100644 --- a/lang/c++/impl/parsing/Symbol.hh +++ b/lang/c++/impl/parsing/Symbol.hh @@ -19,6 +19,7 @@ #ifndef avro_parsing_Symbol_hh__ #define avro_parsing_Symbol_hh__ +#include #include #include #include