Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: tmp* folders are not deleting after execution of some tests #244

Open
markovamaria opened this issue Jul 3, 2023 · 1 comment
Open
Assignees
Labels
bug Something isn't working triage On triage by Performance Group

Comments

@markovamaria
Copy link
Collaborator

markovamaria commented Jul 3, 2023

Describe the bug
tmp* folders are not deleting after execution of some tests.
For benchmark version 72, home directory has 12 empty tmp* directories per run after execution.

To Reproduce
Steps to reproduce the behavior:

$ numactl --physcpubind=1 ./r_servers/redis-server --protected-mode no --port 6379 --dir run_server_logs --logfile run_server.log --save "" &
$ server_pid=$!
$ redis-benchmarks-spec-client-runner --db_server_host localhost --db_server_port 6379 --client_aggregated_results_folder ./run --flushall_on_every_test_start --flushall_on_every_test_end
$ kill -9 $server_pid 

Expected behavior
There is no empty tmp* directories in home directory after execution.

Screenshots
for 3 runs home dir constains 36 empty tmp dirs after execution
image

@markovamaria markovamaria added bug Something isn't working triage On triage by Performance Group labels Jul 3, 2023
@mpozniak95
Copy link
Collaborator

mpozniak95 commented Aug 29, 2023

From what I found in the code, temporary directory isn't deleted when benchmark is skipped for any reasons (f.e. WARNING Skipping test memtier_benchmark-1key-geo-60M-elements-geohash giving it implies dataset preload) because there is continue right after check. Could it be the case here?

Also running redis-benchmarks-spec-client-runner with --dry-run flag results in creating X empty temporary directories (where X is the number of run benchmarks) that are never deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage On triage by Performance Group
Projects
None yet
Development

No branches or pull requests

3 participants