Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky withConn Tests in internal_test.go #3165

Open
Parvezkhan0 opened this issue Oct 19, 2024 · 1 comment
Open

Flaky withConn Tests in internal_test.go #3165

Parvezkhan0 opened this issue Oct 19, 2024 · 1 comment

Comments

@Parvezkhan0
Copy link

I observed that the withConn tests in internal_test.go often fail due to connection errors. Interestingly, they tend to pass in the CI environment.

Details:

The tests are designed to establish a connection to Redis at 127.0.0.1:6379, but the test setup does not initiate a Redis server. In the CI pipeline, these tests succeed because another Redis instance is running for a different test case.

Additionally, it's worth noting that these withConn tests are located within the Redis package, rather than in redis_test, where the BeforeSuite function initializes Redis.

@ndyakov
Copy link
Collaborator

ndyakov commented Feb 7, 2025

Hello @Parvezkhan0, thank you for reporting this. We are working on improving the test setup, but it will be done in couple of iterations. If you have any other suggestions on how to do this, please share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants