Params with text '-' as prefix are not rendered

[blues-man]

With 0.1.12 version, any text (not link) with - character that comes before a query param is not rendered.

Example:

?PROJECT=workshop&CLUSTER_SUBDOMAIN=apps.crc.testing

[source,text,role="copypaste",subs="+attributes"]
----
http://nationalparks-%PROJECT%.%CLUSTER_SUBDOMAIN%
----

Will be rendered as:

http://nationalparks-%PROJECT%.apps.crc.testing

Probably this regexp is not matching it correctly?

[hatmarch]

The issue is in code that I believe @kameshsampath wrote. For some reason the code explicitly won't match anything that begins with -% or ends with %- if I'm reading the regex right. In our case the regex turns out like this

re = /(%25PROJECT%25|(?<!-)%PROJECT%(?!-))/gi

which causes %PROJECT% in your URL to not get replaced.

[hatmarch]

Looks like this came in commit: db18c1d. Commit message implies it that it is to keep "placeholders in the code block" from being replaced

@blues-man, do you know what these placeholders might refer to and whether the starter-workshop makes use of this?

[evanshortiss]

I just helped @danieloh30 workaround this. I have a fork that reverts the negative lookbehind part of the regex: https://github.com/evanshortiss/course-ui/blob/fix-url-hyphen-substitution/src/js/07-userparams-behaviour.js

It would be good to understand why this change was made as @hatmarch asks.

[danieloh30]

Thx for the help @evanshortiss I

As Evan said, it works for me. Hope this fix will be applied to the new version soon.

[evanshortiss]

Oh, and BTW. To test this reverted regular expression with your content:

1. change ui.bundle.url property in the dev-site.yml to https://github.com/evanshortiss/course-ui/releases/download/v0.1.13-prerelease/ui-bundle.zip
2. run rm -rf .cache/ gh-pages node_modules inside your repository
3. run npm install
4. run npm run dev
5. check the results in a web browser

[danieloh30]

good to know. I actually updated the url in dev-site.yml, then just ran npm run dev

[evanshortiss]

You can probably be OK with just making that change, but I am recommending a clean slate to be safe 😉

[danieloh30]

I got you! I will follow your tip next time :)