Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFE] Support user-defined lab_name for dynamic inventory and wiki #537

Closed
sadsfae opened this issue Oct 7, 2024 · 1 comment
Closed

[RFE] Support user-defined lab_name for dynamic inventory and wiki #537

sadsfae opened this issue Oct 7, 2024 · 1 comment
Assignees
@athiruma
Labels
enhancement quads-web wiki
Milestone
2.x Series - Bowie

Comments

@sadsfae
Copy link
Member

sadsfae commented Oct 7, 2024

Currently people need to edit these files to change the inventory page and navigation bar header to change the lab name:

https://github.com/redhat-performance/quads/blob/latest/src/quads/web/templates/navbar.html#L2
https://github.com/redhat-performance/quads/blob/latest/src/quads/web/templates/wiki/inventory.html#L5

This RFE covers making a new conf variable called lab_name for this value so it can be more easily configurable.
@sadsfae sadsfae added this to the 2.x Series - Bowie milestone Oct 7, 2024
sadsfae added a commit that referenced this issue Oct 7, 2024
@sadsfae
doc: how to change web env name/reference.
e12d56b 
* Document two places that need to change for the lab name to change in
  quads-web inventory and wiki.
* Update RPM spec comments for branch differences.

related-to: #537
Change-Id: I76ed868863f952329af021a36d954503a3fe4a8d
@redhat-performance redhat-performance deleted a comment from athiruma Dec 3, 2024
@sadsfae
Copy link
Member Author

sadsfae commented Dec 3, 2024

Review in-progress: https://review.gerrithub.io/c/redhat-performance/quads/+/1205094

@sadsfae sadsfae closed this as completed in 593644d Dec 9, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in QUADS 2.1 Series Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athiruma athiruma

Labels
enhancement quads-web wiki
Projects
QUADS 2.1 Series
Status: Done
Milestone
2.x Series - Bowie
Development

No branches or pull requests
2 participants
@sadsfae @athiruma