Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Confusing naming convention for bridges #154

Open
dougbtv opened this issue Jan 5, 2018 · 1 comment
Open

[cleanup] Confusing naming convention for bridges #154

dougbtv opened this issue Jan 5, 2018 · 1 comment

Comments

@dougbtv
Copy link
Member

dougbtv commented Jan 5, 2018

While running through some of the Multus CRD stuff, I realized I had made some mistakes due to a wonky naming scheme for the bridges.

bridge_name: br0
bridge_network_name: "br0"
  • bridge_name: refers to the name of the bridge in the VM spin up script
  • bridge_network_name: refers to the name of the bridge as created on the virt host.

I think that having two different variables here is actually good -- because sometimes you want to create the bridge on the virthost, and optionally use it -- or not. E.g. sometimes you'd create br0 (via bridge_network_name) on the virthost, and then you'd actually specify virbr0 (via bridge_name) to have NAT'd VMs on the virthost, sometimes at least.

In the end, these should maybe get named, or, note here for if/when the virthost plays get broken out otherwise.

@leifmadsen
Copy link
Contributor

hrmmm.... how about...

  • host_bridge_name
  • virt_bridge_name

?

@leifmadsen leifmadsen changed the title Confusing naming convention for bridges [cleanup] Confusing naming convention for bridges Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants