Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Components" sidebar section take a while to load #3850

Open
datho7561 opened this issue Jan 29, 2024 · 1 comment · May be fixed by #4473
Open

"Components" sidebar section take a while to load #3850

datho7561 opened this issue Jan 29, 2024 · 1 comment · May be fixed by #4473
Assignees

Comments

@datho7561
Copy link
Contributor

When starting up, the "Components" sidebar takes a while to load (a couple of seconds).

A further investigation will need to be performed as to why (eg. which function calls take the longest).

@datho7561 datho7561 self-assigned this Feb 5, 2024
@datho7561
Copy link
Contributor Author

Here's how to reproduce the slowness:

  1. set up your kubeconfig to point to an invalid cluster. In my case, I point it to my local crc instance, but don't start crc
  2. launch VS Code, then open the OpenShift sidebar. All the views in the sidebar should take over a minute to load.

Here is the different layes

  1. We call getAllComponents() in activate
  2. This calls OdoWrapper.Instance.getRegistries() to get the list of registries
  3. getRegistries() uses odo preference view -o json in order to dump the config as JSON, which contains the list of registries.

In the version of odo that we bundle with the extension (3.15.0), this call takes ~40 seconds if the cluster is inaccessible. i.e. you can replicate this slow response on command line by calling odo preference view -o json using odo 3.15.0 . Therefore, the root cause is an upstream issue.

However, we can mitigate the implications of this issue by not calling getAllComponents in activate. I don't know why we were doing this anyways, fetching and updating the list of devfile registries should be encapsulated in the registry tree view.

datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Feb 5, 2024
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Feb 6, 2024
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Feb 6, 2024
datho7561 added a commit to datho7561/vscode-openshift-tools that referenced this issue Feb 6, 2024
datho7561 added a commit that referenced this issue Feb 7, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 13, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 13, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 14, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 14, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 14, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 14, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 14, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 14, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 15, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 15, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 16, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 16, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 16, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 16, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 16, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 16, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 16, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 16, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 16, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 20, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 20, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 20, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 20, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 20, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 23, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 24, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 24, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 24, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 24, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 24, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 24, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 24, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Sep 24, 2024
vrubezhny added a commit to vrubezhny/vscode-openshift-tools that referenced this issue Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

3 participants