From 5a7d0dde9992986a2e8b429953a5a53d78ed3a03 Mon Sep 17 00:00:00 2001 From: Nil Gallego Date: Wed, 20 Nov 2024 22:14:58 +0100 Subject: [PATCH 1/2] adding general rules --- docs/e2e-tests/CONTRIBUTING.MD | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/docs/e2e-tests/CONTRIBUTING.MD b/docs/e2e-tests/CONTRIBUTING.MD index 6f36164e3a..b37f7034a8 100644 --- a/docs/e2e-tests/CONTRIBUTING.MD +++ b/docs/e2e-tests/CONTRIBUTING.MD @@ -37,6 +37,13 @@ These principles are valid for new contributions. Some parts of the codebase may All architecture principles and guidelines must be agreed upon by the team. Every team member's voice is important, and open communication ensures alignment and shared understanding of the project's direction. +6. **General Rules** + + All tests have to follow a set of simple rules: + I. Check the preconditions. If tests are running in parallel, try to create the preconditions you need to avoid race conditions. + II. Each test has to test one and only one thing. + III. All tests have to contain preconditions, actions, and assertions. _Think in [Gherkin](https://cucumber.io/docs/guides/overview/) terms_. + #### Technical Guidelines 1. **Page Object Model (POM)** From 8f220c95bb7548061051dda419b3f497e8e0bf60 Mon Sep 17 00:00:00 2001 From: Nil Gallego Date: Fri, 22 Nov 2024 10:09:47 +0100 Subject: [PATCH 2/2] Update CONTRIBUTING.MD --- docs/e2e-tests/CONTRIBUTING.MD | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/e2e-tests/CONTRIBUTING.MD b/docs/e2e-tests/CONTRIBUTING.MD index b37f7034a8..7353956d4a 100644 --- a/docs/e2e-tests/CONTRIBUTING.MD +++ b/docs/e2e-tests/CONTRIBUTING.MD @@ -42,7 +42,7 @@ These principles are valid for new contributions. Some parts of the codebase may All tests have to follow a set of simple rules: I. Check the preconditions. If tests are running in parallel, try to create the preconditions you need to avoid race conditions. II. Each test has to test one and only one thing. - III. All tests have to contain preconditions, actions, and assertions. _Think in [Gherkin](https://cucumber.io/docs/guides/overview/) terms_. + III. All tests have to contain preconditions, actions, and assertions, like you whould do in [Gherkin](https://cucumber.io/docs/guides/overview/); think in those terms. #### Technical Guidelines