Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHIDP-3260: rename dynamic plugins npmrc secret #38

Conversation

coreydaley
Copy link
Member

@coreydaley coreydaley commented Jul 21, 2024

Description of the change

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@openshift-ci openshift-ci bot requested review from gazarenkov and tumido July 21, 2024 23:48
@coreydaley
Copy link
Member Author

@rm3l @gazarenkov ptal

@coreydaley coreydaley changed the title 2024 07 21 rename dynamic plugins npmrc secret RHIDP-3260: rename dynamic plugins npmrc secret Jul 22, 2024
@coreydaley coreydaley force-pushed the 2024-07-21-rename-dynamic-plugins-npmrc-secret branch from cadeb6a to 8150a79 Compare July 24, 2024 04:18
Rename the dynamic-plugins-npmrc secret to be specific to the instance
of the Helm Chart with which it is associated so as to support
multiple helm installs in one namespace
@coreydaley coreydaley force-pushed the 2024-07-21-rename-dynamic-plugins-npmrc-secret branch from 8150a79 to a96305c Compare July 24, 2024 04:23
Copy link

sonarcloud bot commented Jul 24, 2024

@coreydaley coreydaley merged commit 7969b8c into redhat-developer:main Jul 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants