-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed deprecation warning about backend.auth.keys #31
Removed deprecation warning about backend.auth.keys #31
Conversation
…d.auth.keys Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
…d.auth.keys Signed-off-by: Kashish Mittal <[email protected]>
I think that you also need to run the pre-commit hook to regenerate the schema and update the README |
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
/cc @rm3l
|
@rm3l: once the present PR merges, I will cherry-pick it on top of 1.2.x in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine - thanks @04kash !! For the reasons mentioned in https://issues.redhat.com/browse/RHIDP-2716?focusedId=25057410&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-25057410, this PR should not be cherry-picked to 1.2.x
.
Signed-off-by: Kashish Mittal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests not passing because the latest
tag for quay.io/janus-idp/backstage-showcase
is outdated, and the changes here won't work on RHDH 1.1
Logs
/opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1481
throw new Error(
^
Error: Failed to instantiate service 'core.tokenManager' for 'search' because the factory function threw an error, Error: Failed to instantiate service 'core.tokenManager' because createRootContext threw an error, Error: You must configure at least one key in backend.auth.keys for production.
at /opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1481:17
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async BackendInitializer.getInitDeps_fn (/opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1644:20)
at async /opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1779:32
at async processNode (/opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1302:22)
at async Promise.all (index 0)
at async processMoreNodes (/opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1297:7)
at async _DependencyGraph.parallelTopologicalTraversal (/opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1308:5)
at async /opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1777:9
at async Promise.all (index 4)
at async BackendInitializer.doStart_fn (/opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1757:3)
at async BackendInitializer.start (/opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1611:5)
at async BackstageBackend.start (/opt/app-root/src/node_modules/@backstage/backend-app-api/dist/index.cjs.js:1881:5)
Node.js v18.18.2
I think quay.io/janus-idp/backstage-showcase:latest
should be updated to the latest stable version of the Showcase app.
See https://redhat-internal.slack.com/archives/C04CUSD4JSG/p1720191475569659
/hold
@rm3l So do we need to change the image here to point to next instead? |
We discussed in https://redhat-internal.slack.com/archives/C04CUSD4JSG/p1720191475569659 (https://issues.redhat.com/browse/RHIDP-3157) that it would probably make more sense to use the downstream RHDH image here. |
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
/hold cancel |
/lgtm |
/approve |
@04kash Are you ready for us to merge this? |
Yes |
Description of the change
Fixed default configuration to remove deprecation warning about backend.auth.keys by replacing it with https://github.com/backstage/backstage/blob/master/beps/0007-auth-external-services/README.md#the-legacy-access-type
Existing or Associated Issue(s)
Fixes: https://issues.redhat.com/browse/RHIDP-2716
Additional Information
Checklist
Chart.yaml
according to semver.values.yaml
and added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -a
to apply changes.pre-commit
hook.ct lint
command.