chore(ci): replace usage of slash-command-action #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`xt0rted/slash-command-action` uses deprecated Node.js versions. This PR replaces the logic with `actions/github-script` and `create-or-update-comment`. Both of these actions are more actively maintained.`
|
/lgtm |
|
Seems OK but would want to merge this and then run a bump to ensure it works as expected |
|
@nickboldt does that mean this needs to wait to land at an appropriate/specific time? |
|
merged. build succeeded and created 2.16.6 from PR #35 also seeing https://artifacthub.io/packages/helm/rhdh-chart/backstage refreshed with the latest version \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
xt0rted/slash-command-actionuses deprecated Node.js versions- I did try opening a PR to the action to update the Node.js versions used but it has had no traction.As such, this PR replaces the logic with
actions/github-scriptandcreate-or-update-comment. Both of these actions are more actively maintained.Note that this only impacts the bump-version.yml workflow.
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -ato apply changes.pre-commithook.ct lintcommand.