Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added telemetry opt-in banner #15

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

04kash
Copy link

@04kash 04kash commented May 30, 2024

Description of the change

Added the telemetry opt-in banner to the following files: README.md and charts/backstage/Chart.yaml

Existing or Associated Issue(s)

Closes https://issues.redhat.com/browse/RHIDP-1906

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@04kash 04kash requested a review from a team as a code owner May 30, 2024 16:49
@openshift-ci openshift-ci bot requested review from davidfestal and kadel May 30, 2024 16:49
charts/backstage/Chart.yaml Show resolved Hide resolved
charts/backstage/Chart.yaml Outdated Show resolved Hide resolved
@rm3l
Copy link
Member

rm3l commented May 31, 2024

/hold

As commented out in janus-idp/operator#372 (comment), https://access.redhat.com/documentation/en-us/red_hat_developer_hub/1.2/html-single/administration_guide_for_red_hat_developer_hub/index#assembly-rhdh-telemetry_admin-rhdh currently returns a 404.
Before merging this PR, should we wait until confirmation that the URL is correct?

04kash and others added 2 commits May 31, 2024 09:55
Signed-off-by: Kashish Mittal <[email protected]>
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rm3l
Copy link
Member

rm3l commented Jun 3, 2024

As commented out in janus-idp/operator#372 (comment), access.redhat.com/documentation/en-us/red_hat_developer_hub/1.2/html-single/administration_guide_for_red_hat_developer_hub/index#assembly-rhdh-telemetry_admin-rhdh currently returns a 404. Before merging this PR, should we wait until confirmation that the URL is correct?

Got confirmation from @nickboldt that the URL appears to be correct.

/hold cancel

@nickboldt nickboldt merged commit b98eb6d into redhat-developer:main Jun 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants