Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme for extension catalog #49

Closed
jeffmaury opened this issue Apr 24, 2024 · 1 comment · Fixed by #50
Closed

Update readme for extension catalog #49

jeffmaury opened this issue Apr 24, 2024 · 1 comment · Fixed by #50
Assignees
@feloy

Comments

@jeffmaury
Copy link
Member

Is your enhancement related to a problem? Please describe

The Red Hat Image Checker extension will now appear in the Podman Desktop extension catalog.

Describe the solution you'd like

We need to:

  • Update the installation instructions
  • Make sure the readme looks good inside PD (e.g. likely means absolute paths for images)

Describe alternatives you've considered

No response

Additional context

No response
@jeffmaury jeffmaury moved this to 📅 Planned in Podman Desktop Planning OLD Apr 24, 2024
@benoitf
Copy link

benoitf commented Apr 25, 2024

note: There is a README.md included in the extension but this one is empty
https://github.com/redhat-developer/podman-desktop-image-checker-openshift-ext/blob/main/podman-desktop-extension/README.md

so this is the one being displayed when extension is installed.

During building the extension, it should take the README of the repository, not the one from the extension folder which is empty

@feloy feloy mentioned this issue Apr 29, 2024
Merged
@feloy feloy moved this from 📅 Planned to 🚥 In Review in Podman Desktop Planning OLD Apr 29, 2024
@feloy feloy closed this as completed in #50 Apr 30, 2024
@github-project-automation github-project-automation bot moved this from 🚥 In Review to ✔️ Done in Podman Desktop Planning OLD Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feloy feloy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update README for extension catalog feloy/podman-desktop-image-checker-openshift-ext
3 participants
@benoitf @jeffmaury @feloy