New suggestion system broke path suggestion in bash/zsh

[kadel]

[kind/bug]

If I run odo create wildfly --local ./<tab> I don't get path suggestions :(

[mik-dass]

@kadel Added a quick PR for this. But the PR currently doesn't work for ~ and ../ but it does work for / and other normal situations

[kadel]

Reopening this, as #962 was supposed to fix this only partially. But I couldn't every even that :-(

[mik-dass]

@kadel @anmolbabu It might be a better idea to fix it upstream in posener/complete. WDYT?

[anmolbabu]

@kadel @anmolbabu It might be a better idea to fix it upstream in posener/complete. WDYT?

@mik-dass Ack Sounds good to me and raised a PR posener/complete#76 on their repo to add fix for ~ but it seems they are differently handling ../(actually /..) for some strange reason otherwise unlike ~ which is a shell symbol, ./ and ../ are very much recognized by golang's file handling apis... I am looking deeper into their code as to why ../ doesn't work and how that can be fixed..

I am just hoping that the first part of fixing ~ goes in quickly 🤞

Cc: @kadel

[anmolbabu]

Ideally, looking at their current code, I doubt posener/complete would work well on windows at the moment 😞

[mik-dass]

@anmolbabu I will try to check on windows if I find a suitable machine

[surajnarwade]

Closing this as we dont have --local flag but we do have --context and suggestions are working for it 🎉

@kadel , reopen if it's not working for you