Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_file_location in filter_plugin might be doing too much #100

Open
etsauer opened this issue Jan 29, 2019 · 1 comment
Open

check_file_location in filter_plugin might be doing too much #100

etsauer opened this issue Jan 29, 2019 · 1 comment

Comments

@etsauer
Copy link
Contributor

etsauer commented Jan 29, 2019

We've addressed immediate issues like #91 with PR #97, so this isn't urgent. However, I still believe that the filter_plugin methods should not attempt to verify that a URL returns a healthy response. Specifically, there are two cases we are likely to hit in the future where this will create false negatives:

  1. Unexpected return codes
  • In cases where we are either operating in environments behind a proxy, or pointing at a location behind proxies with unexpected configs, its possible we could get a non 200 response code that will work perfectly fine when passe to oc
  1. Untrusted CAs
  • It's reasonable to expect a consumer of applier may be hosting remote yml files on servers where Python may not trust the CA, but oc does. Think gogs running on openshift with the openshift signed, or customer signed certificate

For this reason, I think that the functionality within the check_file_location should only check for the characteristics of a URL (scheme, hostname, path) instead of actually trying to follow all URLs passed by the user.

@oybed
Copy link
Contributor

oybed commented Jan 30, 2019

@etsauer so I think this may fit in with a bigger refactor/re-design of the openshift-applier. Maybe we can take a step back to consider some higher level architecture changes, including:

  • Multi-cluster support
  • Re-structuring of inventory for multi-cluster and multi-target support
    • Overall re-structuring of inventory based on feedback from users (e.g.: the use of host_vars v.s. group_vars)
  • "Operator - or not to Operator" - i.e.: how to architect the "next-gen" openshift-applier for co-existence with operators
  • The name - i.e.: "openshift-applier" v.s. something else

I think if we work the above, the items outlined in this issue may become resolved as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants