support OKD4

[walidshaari]

the current repo has many settings which are wired to ocp4, it would be nice if we can expand it to OKD4

[christianh814]

Which sections, that cannot be altered by a vars.yaml file is hardcoded to OCP4? The playbook should work with OKD4 artifacts.

[walidshaari]

I see your point as long as we can override them as variables, yes, it should be fine or add them in the vars examples, I see one example that is close https://github.com/RedHatOfficial/ocp4-helpernode/blob/master/docs/examples/vars-nightlies.yaml, will have to test it.

[christianh814]

Good point, it would be nice to at least have an example. If you could get a sample vars.yaml that works, I can include it in the examples

[christianh814]

@walidshaari Actually, it might not work. see #134 ...the new version of RHCOS will now require a new artefact that the helper doesn't account for currently.

As it stands, the helper will not work with OKD until version 4.6 comes out. I don't want to really make changes with a lot of conditionals if we just need to remove them for 4.6.

I'll leave this open and will come back this this once OCP v4.6 is GA.

[christianh814]

..well...maybe not coreos/fedora-coreos-tracker#390 (comment)

[walidshaari]

let me know if there is a task I can take.

[christianh814]

@walidshaari Please do! I would verify to see if it works "as is"