Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0_beta - id´s needs to be unique - seo enhancement #5635

Open
Rmh1978 opened this issue Sep 17, 2023 · 0 comments
Open

4.0.0_beta - id´s needs to be unique - seo enhancement #5635

Rmh1978 opened this issue Sep 17, 2023 · 0 comments

Comments

@Rmh1978
Copy link
Contributor

Rmh1978 commented Sep 17, 2023

What version of redShop has the issue?
4.0.0_beta

What version of Joomla has the issue?
4.3.4

What php version has the issue? - Can be found Joomla Home dashboard > Site Information. redShop is for min. php8
8.0.30

What view did you experience the issue? - e.g. Site > product detail view
Site category view with filters

What did error reporting state? - Can be enabled in Joomla Backend > System > Global Configuration > Server > Error Reporting= Maximum
N/A

What did Chrome inspector console state? - Right-click on the page and click "Inspect"
Found 3 elements with non-unique id #category_template:
Found 3 elements with non-unique id #manufacturer_id:
Found 3 elements with non-unique id #order_by:

Describe the issue
The 3 id´s needs to be unique for each filter form

Fix - If you have already made a fix but unable to do it on Github then write it here
The files to edit is here:
libraries/redshop/layouts/tags/category/filter_form.html.twig
libraries/redshop/layouts/tags/category/orderby_form.html.twig
libraries/redshop/layouts/tags/category/template_selecter_form.html.twig

I didnt investegate if it has any negative effect simply renaming the id´s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant