Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert loops #69

Closed
TheJaredWilcurt opened this issue Aug 26, 2021 · 0 comments · Fixed by #79
Closed

Convert loops #69

TheJaredWilcurt opened this issue Aug 26, 2021 · 0 comments · Fixed by #79
Labels
good first issue Good for newcomers testing Writing automated tests

Comments

@TheJaredWilcurt
Copy link
Member

arr.forEach() is used a lot, however, if we switch to for (let i = 0; i < things.length; i++) {} or for (let thing of things) {} then users have greater control, like a hook being able to add/remove additional tasks mid-run. This would allow for more dynamic build options/tooling.
@TheJaredWilcurt TheJaredWilcurt added good first issue Good for newcomers testing Writing automated tests labels Aug 29, 2021
aslamdoctor added a commit to aslamdoctor/red-perfume-task-runner that referenced this issue Jan 22, 2023
@aslamdoctor
[red-perfume#69] Convert loops
6d44805 
Convert forEach loops into for loop.
Fixes red-perfume#69
@aslamdoctor aslamdoctor mentioned this issue Jan 22, 2023
Merged
2 tasks
aslamdoctor added a commit to aslamdoctor/red-perfume-task-runner that referenced this issue Jan 22, 2023
@aslamdoctor
[red-perfume#69] Convert loops
6d1fe48 
Convert `forEach` loops to `for` loop for flexibility purpose.
@github-project-automation github-project-automation bot moved this from Todo to Done in Red-Perfume Project Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers testing Writing automated tests
Projects
Red-Perfume Project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#69] Convert loops aslamdoctor/red-perfume-task-runner
1 participant
@TheJaredWilcurt