-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Country code should come from address #14
Comments
My propose a revision to the address field in the meeting-guide.html file to improve user experience and data accuracy. Currently, the separate country field defaults to "USA" and may not accommodate users from other countries. I recommend implementing a nested address object or a single address field with a standardized format. Alternatively, a separate country field with a dropdown or autocomplete feature can be used. These solutions will simplify the address input process, reduce errors, and enhance overall usability. let's discuss further detail. |
@kabeer95 I'm having a little trouble understanding your contribution to the conversation. It looks like you summarized what I mentioned and suggested discussing it further. Is there something specific you wanted to add or elaborate on that I might have overlooked? |
@MTecknology what i am trying to say is , instead of going for 5th field you can use construcut for the field to default |
@kabeer95 It sounds like you're basically describing how it works right now; check out the link in the description. |
It's also worth noting that TSML /does/ put the country field into the normalized address. Trying to parse this data is what made me create this ticket--because I'm not convinced either approach is truly best ... but what else is there? |
https://github.com/recoverysource/aamod/blob/master/layouts/shortcodes/meeting-guide.html#L23 defines a separate country field that automatically defaults to USA. The default seems fine, but this should not rely on an entirely separate field. We should instead support adding it as an optional 5th argument to our address ... actually, this seems worse than current.
There are likely better ways to handle this; discussion is needed.
The text was updated successfully, but these errors were encountered: