Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing readOnly doesn't affect relationship mode #55

Open
rsimon opened this issue Nov 22, 2021 · 2 comments
Open

Changing readOnly doesn't affect relationship mode #55

rsimon opened this issue Nov 22, 2021 · 2 comments

Comments

@rsimon
Copy link
Member

rsimon commented Nov 22, 2021

Not covered by PR #54 yet.

@rsimon
Copy link
Member Author

rsimon commented Dec 3, 2021

Probably won't ever address this, since relationship mode is essentially marked for deprecation now, in favour of the upcoming Connections Plugin.

@apt-get2Update
Copy link

@rsimon I checked the code . If we add 'this.relationsLayer.readOnly = readOnly;' i see that it works as expected. but the documention says we should do that only from set mode.

set readOnly(readOnly) {
    this.selectionHandler.readOnly = readOnly;
    this.relationsLayer.readOnly = readOnly;
    // Note: relationsHandler.readOnly should be set by setMode.
    this.setState({ readOnly });
  }

Does it mean we should set Mode as Relations if readonly is set as false ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants