Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Proposal: Add Drain Precheck #7

Open
svenwltr opened this issue Sep 13, 2018 · 0 comments
Open

Proposal: Add Drain Precheck #7

svenwltr opened this issue Sep 13, 2018 · 0 comments

Comments

@svenwltr
Copy link
Member

We could add some prechecks before draining a node.

An example would be a check whether there are any pending pods in the cluster. This would reduce the damage if some admin is too eager with scaling down the instances. Example scenario:

  • admin needs to replace one ASG with another
  • the new ASG is ready and the old ones are cordoned
  • the admin scales down the old ASG in chunks of 3
  • the new ASG actually is not big enough, therefore scheduling pod from the last chunk might fail
  • node-drainer happily continues draining the remaining nodes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant