Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sqlfluff dependency to 3.1.0+ #644

Open
KulykDmytro opened this issue Aug 13, 2024 · 2 comments · May be fixed by #660
Open

Upgrade sqlfluff dependency to 3.1.0+ #644

KulykDmytro opened this issue Aug 13, 2024 · 2 comments · May be fixed by #660
Labels
enhancement New feature or request

Comments

@KulykDmytro
Copy link

KulykDmytro commented Aug 13, 2024

Describe the solution you'd like
Upgrade sqlfluff dependency to 3.1.0+
There are many needed fixes happened

@KulykDmytro KulykDmytro added the enhancement New feature or request label Aug 13, 2024
@KulykDmytro KulykDmytro changed the title Upgrade sqlfluff dependency to 3.1.0+ Upgrade sqlfluff dependency to 3.1.0+ Aug 13, 2024
@shoffmeister
Copy link

FWIW, I just built (and only built!) sqllineage from source, with the sqlfluff dependency set to 3.1.1 - all tests are passing, without any further change in sqllineage.

This would suggest that locally you could simply run sqllineage in a virtual environment of its own, and then simply upgrade the sqlfluff dependency using pip?

(Granted a new release of sqllineage with latest sqlfluff would be more convenient, but then sqlfluff seems to move at an astonishing pace, which I can imagine makes it challenging to track that)

@shoffmeister
Copy link

FWIW, I verified that running

pip install --upgrade https://github.com/sqlfluff/sqlfluff/tarball/master

in "my" sqllineage Python virtual environment did complete to success (I needed sqlfluff master)

I also got the graph and the output that I wanted out of that hot-patched installation of sqllineage.

Your mileage may vary.

@rubytobi rubytobi linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants