Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refmt produces invalid code in JSX with fast pipe and field access #2573

Open
vdanchenkov opened this issue May 10, 2020 · 3 comments
Open

refmt produces invalid code in JSX with fast pipe and field access #2573

vdanchenkov opened this issue May 10, 2020 · 3 comments
Labels
Printer things that have to do with turning an AST into Reason code

Comments

@vdanchenkov
Copy link 

let out = <div> {f(x).value->React.string} </div>;

formats to

let out = <div> f(x).value->React.string </div>;

formats to

let out = <div> f x.value->React.string </div>;

Related to #2199

Checked on https://reasonml.github.io/en/try
@vdanchenkov vdanchenkov changed the title refmt produces invalid code in JSX refmt produces invalid code in JSX with fast pipe and field access May 10, 2020
@bloodyowl
Copy link
Contributor

What BuckleScript version are you using?

@vdanchenkov
Copy link
Author

vdanchenkov commented May 11, 2020 •
edited
Loading

bs-platform - 7.2.2

$ ./node_modules/.bin/bsrefmt --version
Reason 3.6.0 @ 8f71db0

@bloodyowl
Copy link
Contributor

Oh right, there seems to be an issue with record field access here. poke @anmonteiro as you worked on other fixes in that area.

@davesnx davesnx added the Printer things that have to do with turning an AST into Reason code label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Printer things that have to do with turning an AST into Reason code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bloodyowl @vdanchenkov @davesnx