Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odd indentation when inlining switch expression inside JSX block #2561

Closed
bsansouci opened this issue Apr 7, 2020 · 1 comment
Closed

odd indentation when inlining switch expression inside JSX block #2561

bsansouci opened this issue Apr 7, 2020 · 1 comment
Labels
Printer things that have to do with turning an AST into Reason code

Comments

@bsansouci
Copy link
Contributor

It seems like I get 3 spaces indentation when I inline a switch like such:

<div>
  {switch (x) {
   | 0 => <div />
   | _ => ReasonReact.null
   }}
</div>;

This is annoying because VSCode is particular about spacing being in even numbered chunks, so hitting tab on a new line inside the switch always aligns the indentation back to 4 spaces instead of 5 (3 + 2 spaces). It also makes it harder to read because the indentation lines are every 2 spaces, so this looks clearly misaligned with everything else.

@davesnx davesnx added the Printer things that have to do with turning an AST into Reason code label Nov 16, 2022
@anmonteiro
Copy link
Member

let's track this in #2675

@anmonteiro anmonteiro closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Printer things that have to do with turning an AST into Reason code
Projects
None yet
Development

No branches or pull requests

3 participants