Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long term solution for printing "Outcome Values" in the top level. #226

Open
jordwalke opened this issue Mar 27, 2016 · 0 comments
Open

Comments

@jordwalke
Copy link
Member

For now, @kayceesrk found that it will be very easy to write our own outcome printer by simply forking the upstream ML one. (Or at least we can get it to a very usable state quickly). Longer term, we decided the best approach is to create a general purpose converter from "outcome tree" to "parse tree", where certain nodes in the parse tree would have some kind of placeholder to represent nodes in the outcome tree which could not be represented in a parse tree. (Things like ... for large objects). For those, we could chose to convert them as ppx extension points [%largeObject].

The benefit here, is that the top level printer will always be kept in sync with your parser/printer. The downside is that it will take longer to do it this way, so we are making this issue to track the implementation long term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants