-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
router.init does not work for commonJS #2
Comments
I had to do the same thing with webpack 2.6.1, too. In a regular web application. |
Done! |
I ran into the same problem. |
@guido4000 alright, done! Ping me if there's any problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From Discord:
hey @chenglou#3765, just wanted to let you know that for the webpack "electron-renderer" target (little different than the browser), I had to change the bs-director bindings to point to "director/build/director" instead of director in order to get router.init() to work (per this issue:
flatiron/director#332). Not sure if it's worth adding another external binding like "makeRouterForEnvOtherThanBrowser" (obv. a different name) or if it would be fine to just update the documentation. I copied the bindings over because it's ~4 lines of code, but here's the change:
I can file an issue as well.
The text was updated successfully, but these errors were encountered: