Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: fix linting errors #798

Open
tiborsimko opened this issue May 10, 2024 · 1 comment
Open

helm: fix linting errors #798

tiborsimko opened this issue May 10, 2024 · 1 comment

Comments

@tiborsimko
Copy link
Member

Current behaviour

helm lint currently reports an error for our chart:

$ helm lint helm/reana -f helm/configurations/values-dev.yaml
engine.go:189: [INFO] Fail:

 ERROR: You must have at least networking.k8s.io/v1beta1 to use ingressClass
==> Linting helm/reana

1 chart(s) linted, 0 chart(s) failed

Expected behaviour

Our charts should pass linting error-free.

Bonus

Introduce chart linting to the run-tests.sh and the CI process.

See also https://github.com/helm/chart-testing

@mdonadoni
Copy link
Member

The error is coming from Traefik's subchart (source). Disabling the subchart makes the linter pass without warnings or errors:

$ helm lint helm/reana -f helm/configurations/values-dev.yaml --set traefik.enabled=false
==> Linting helm/reana

1 chart(s) linted, 0 chart(s) failed

@mdonadoni mdonadoni added this to 0.9.4 Jun 27, 2024
@mdonadoni mdonadoni moved this to Ready for work in 0.9.4 Jun 27, 2024
Alputer added a commit to Alputer/reana that referenced this issue Sep 10, 2024
@tiborsimko tiborsimko removed this from 0.9.4 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants