You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, in case of a CWL or Snakemake workflow, it is also possible to load parameters from an external file by providing a special input parameter (source code)
inputs:
parameters:
input: my-parameters.yaml
We should introduce a new property in reana.yaml to support loading parameters from a file also for serial or Yadage workflows. One possible name for this property can be parameter_file (or parameterfile):
inputs:
parameter_file: my-parameters.yaml
If we want to support multiple parameter files at the same time, then we should use parameter_files (or parameterfiles) instead:
Making this "parameter input file" clearer and better structured is definitely a nice and needed improvement.
In the rest of reana.yaml it looks to me like we often go for snakecase (see kubernetes_memory_limit, compute_backends, ...), so I would prefer parameter_files.
I also think that being able to support multiple parameter files at the same time is better; in this case, I think that parameters that are defined later should simply override the ones that were defined previously, and issue a warning about this. This is a very commonly followed approach when dealing with duplicate keys (see Oracle DB for example), and users seem to complain about the absence of warnings rather than about being allowed to put duplicate keys (see helm lint, prometheus). Note that this is something we have to address anyway, as right now the current code does not complain for duplicated keys in the same parameter file, but just overrides the first one with the value of the second (because this is how yaml.load behaves).
Parameters of a workflow are specified in the
inputs.parameters
section ofreana.yaml
, like this:However, in case of a CWL or Snakemake workflow, it is also possible to load parameters from an external file by providing a special
input
parameter (source code)We should introduce a new property in
reana.yaml
to support loading parameters from a file also for serial or Yadage workflows. One possible name for this property can beparameter_file
(orparameterfile
):If we want to support multiple parameter files at the same time, then we should use
parameter_files
(orparameterfiles
) instead:In this second case, we also need to decide how to handle parameters defined in different files but having the same name.
The text was updated successfully, but these errors were encountered: