Skip to content

Commit 8f03832

Browse files
Linting docs
1 parent 38b984e commit 8f03832

File tree

3 files changed

+27
-19
lines changed

3 files changed

+27
-19
lines changed

CONTRIBUTING.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ We welcome your contributions to the project. There are a few steps to take when
99
- Update the docs for any API changes.
1010
- Submit a pull request.
1111

12-
# Bug Reporting
12+
## Bug Reporting
1313

1414
Shopify App Express package for Node uses GitHub issue tracking to manage bugs, please open an issue there.
1515

16-
# Feature Request
16+
## Feature Request
1717

1818
You can open a new issue on the GitHub issues and describe the feature you would like to see.
1919

20-
# Developing the package
20+
## Developing the package
2121

2222
Requirements:
2323

@@ -26,7 +26,7 @@ Requirements:
2626

2727
You can set up your development environment by running the following:
2828

29-
```
29+
```shell
3030
git clone [email protected]:Shopify/shopify-app-js.git # get the code
3131
cd shopify-app-js # change into the source directory
3232
yarn install # install dependencies

README.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# `@shopify/shopify-app-js`
22

3-
This repo is a collection of packages makes it easy for [Express.js](https://expressjs.com/) apps to integrate with Shopify. The main package is `@shopify/shopify-app-express`, which builds on the `@shopify/shopify-api` package and creates a middleware layer that allows the app to communicate with and authenticate requests from Shopify. Also included are a variety of `SessionStorage` packages for different storage mechanisms that are compatible with the Express package for storing sessions.
3+
This repo is a collection of packages makes it easy for [Express.js](https://expressjs.com/) apps to integrate with Shopify.
4+
5+
The main package is `@shopify/shopify-app-express`, which builds on the `@shopify/shopify-api` package and creates a middleware layer that allows the app to communicate with and authenticate requests from Shopify.
6+
7+
This repo also contains a variety of `SessionStorage` packages for different storage mechanisms that are compatible with the Express package for storing sessions.
48

59
See the respective `README.md` files in the [packages](packages) sub-directories for more details.

RELEASING.md

+18-14
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,12 @@
22

33
1. The `shopify-app-js` repo uses `changesets` to track and update the respective `CHANGELOG.md` files within the packages.
44

5-
1. When creating a PR, the author should run the `yarn changeset` command, answer the relevant questions (i.e., what packages does this PR update, is it major/minor/patch, what is the change description), and then commit the new file created in the `.changeset` directory. These files are used by the workflows to construct the `CHANGELOG.md` entries.
5+
1. When creating a PR, the author should run the `yarn changeset` command, answer the relevant questions (i.e., what packages does this PR update, is it major/minor/patch, what is the change description), and then commit the new file created in the `.changeset` directory. These files are used by the workflows to construct the `CHANGELOG.md` entries.
66

7-
> Note: If the change is very small and doesn't warrant a changelog entry, run `yarn changeset --empty` and commit the resultant file in the `.changeset` directory.
7+
> **Note**
8+
> If the change is very small and doesn't warrant a changelog entry, run `yarn changeset --empty` and commit the resultant file in the `.changeset` directory.
89
9-
1. When the PR is merged into the `main` branch, the `main-release.yml` workflow uses the `changesets/action` to either create or update an existing PR that has the title `Version Packages`. This PR tracks all the changes currently being made against the `main` branch since the last release.
10+
1. When the PR is merged into the `main` branch, the `main-release.yml` workflow uses the `changesets/action` to either create or update an existing PR that has the title `Version Packages`. This PR tracks all the changes currently being made against the `main` branch since the last release.
1011

1112
1. To perform a release, check the details of the `Version Packages` PR, and merge it into `main`.
1213

@@ -16,13 +17,15 @@
1617

1718
For significant changes that could result in significant refactoring on the part of developers, consider releasing a few _Release Candidate_ versions in advance of the final version.
1819

19-
> Note: These changes **must** be made against the `next` branch, so that the appropriate workflows can run (`next-release.yml`).
20+
> **Note**
21+
> These changes **must** be made against the `next` branch, so that the appropriate workflows can run (`next-release.yml`).
2022
21-
1. Prior to creating PR, run the `yarn changeset pre enter rc` command and commit the resultant files from `.changeset`, including the `pre.json` file. This informs `changesets` that it is in pre-release mode, and the pre-release tag is `rc`.
23+
1. Prior to creating PR, run the `yarn changeset pre enter rc` command and commit the resultant files from `.changeset`, including the `pre.json` file. This informs `changesets` that it is in pre-release mode, and the pre-release tag is `rc`.
2224

23-
1. When creating a PR, the author should run the `yarn changeset` command, answer the relevant questions (i.e., what packages does this PR update, is it major/minor/patch, what is the change description), and then commit the new file created in the `.changeset` directory. These files are used by the workflows to construct the `CHANGELOG.md` entries for the release candidates.
25+
1. When creating a PR, the author should run the `yarn changeset` command, answer the relevant questions (i.e., what packages does this PR update, is it major/minor/patch, what is the change description), and then commit the new file created in the `.changeset` directory. These files are used by the workflows to construct the `CHANGELOG.md` entries for the release candidates.
2426

25-
> Note: If the change is very small and doesn't warrant a changelog entry, run `yarn changeset --empty` and commit the resultant file in the `.changeset` directory.
27+
> **Note**
28+
> If the change is very small and doesn't warrant a changelog entry, run `yarn changeset --empty` and commit the resultant file in the `.changeset` directory.
2629
2730
1. When the PR is merged into the `next` branch, the `next-release.yml` workflow uses the `changesets/action` to either create or update an existing PR that has the title `Version Packages for Release Candidates`.
2831

@@ -34,17 +37,18 @@ For significant changes that could result in significant refactoring on the part
3437

3538
When a major set of changes is about to be mass released from the `next` branch
3639

37-
1. Take the `next` branch out of pre-release mode by running
40+
> **Warning**
41+
> The next steps need to be confirmed
3842
39-
```shell
40-
yarn changeset pre exit
41-
```
43+
1. Take the `next` branch out of pre-release mode by running
4244

43-
And commit the changed files.
45+
```shell
46+
yarn changeset pre exit
47+
```
4448

45-
> Warning: the next steps need to be confirmed
49+
And commit the changed files.
4650

47-
1. Merge the `next` branch into `main`. This _should_ update the relevant `CHANGELOG.md` files on `main` with the changes from the release candidates.
51+
1. Merge the `next` branch into `main`. This _should_ update the relevant `CHANGELOG.md` files on `main` with the changes from the release candidates.
4852

4953
1. In the resultant `Version Packages` PR, edit the `CHANGELOG.md` files as needed, as many of the entries may be irrelevant (early release candidate comments no longer applicable) or may be combined.
5054

0 commit comments

Comments
 (0)