Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client should handle and surface http error code 431 (headers_too_large) when sent from the server #7878

Open
sync-by-unito bot opened this issue Jul 10, 2024 · 2 comments
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Jul 10, 2024

Related to the linked HELP ticket, this customer had a really large user object and we found that envoy was rejecting the request.

https://splunk.corp.mongodb.com/en-US/app/search/search?sid=1720636634.1258082&dispatch.sample_ratio=1&display.events.type=raw&display.page.search.mode=smart&q=search%20index%3Denvoy%20client_ip%3D%22188.24.22.213%22&earliest=1720456219.011&latest=1720456224.012

{"upstream_cluster":null,"resp_code":431,"resp_flags":"DPE","user-agent":null,"response_duration":null,"req_method":null,"x-request-id":null,"bytes_received":0,"bytes_sent":31,"upstream_host":null,"resp_code_details":"http1.headers_too_large","upstream-service-time":null,"start_time":"2024-07-08T16:30:19.642506447+0000","request_duration":null,"protocol":"HTTP/1.1","connection_termination_details":null,"response_tx_duration":null,"authority":null,"downstream_direct_remote_address":"188.24.22.213:56515","duration":51,"req_path":null,"client_ip":"188.24.22.213"}

This was not showing up in the logs in any discernable way according to the help ticket (here are the logs they posted) [^01340259 error-1.rtf]

It should be possible to repro this by using custom user data and making the object 1/2 MB (that is what the customer had it as).

The goal of this ticket would be to make sure that this is a clearer error in the logs ideally.

This was happening on this SDK release https://github.com/realm/realm-swift/releases/tag/v10.49.1 which correlates to Realm-Core 14.4.1

Copy link
Author

sync-by-unito bot commented Jul 10, 2024

➤ PM Bot commented:

Jira ticket: RCORE-2195

Copy link
Author

sync-by-unito bot commented Jul 31, 2024

➤ Jonathan Reams commented:

So, core doesn't do anything to hide this error and it's actually the SDK that implements the http client that would have to surface this error. [~[email protected]], is this something the swift SDK would have to change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant