Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does custom_categories support reg expression? #688

Open
liuxuan30 opened this issue Nov 29, 2016 · 7 comments
Open

Does custom_categories support reg expression? #688

liuxuan30 opened this issue Nov 29, 2016 · 7 comments
Assignees

Comments

@liuxuan30
Copy link

liuxuan30 commented Nov 29, 2016

one question, it seems like custom_categories does not support reg expression?
Let's say I have many classes with some prefix: some starts with Line, some starts with Bars:

BarChartView.swift,
BarChartData.swift,
LineChartView.swift,
LineChartDataSet.swift

I want to group them into Line Type and Bar Type,

custom_categories:
  name: Bar Type
     children:
     - Bar*
  name: Line Type
     children:
     - Line*

It won't have any effect. Instead, I have manually list all the classes. Am I wrong?

@pigeondotdev
Copy link
Contributor

Hi @liuxuan30. Thanks for reaching out. I don't believe custom_categories supports regular expressions but I'm going to rope in @jpsim. I'm pretty new so he may have more to say.

@liuxuan30
Copy link
Author

If not supported yet, I guess it would be a good feature to have.. typing multiple names are killing me

@jpsim jpsim added enhancement and removed question labels Dec 7, 2016
@jpsim
Copy link
Collaborator

jpsim commented Dec 7, 2016

We'd love a PR, @liuxuan30!

@galli-leo
Copy link

I think this would make sense to add in combination with #624. Would it be ok, to include both in the same pr?

@johnfairh
Copy link
Collaborator

Personally I'd prefer to see this as a separate PR, should be a simple change on top of the current code.

@galli-leo
Copy link

galli-leo commented Jun 16, 2018

@johnfairh Yeah I quickly tested it yesterday, theoretically it can be a one line change (if we just want to assume any item is a regex).

@JUSTINMKAUFMAN
Copy link

@galli-leo @johnfairh Is there any movement on this? Would love to get it working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants