From 405c0eba001b8c74f0be5b0c2ed4f3b2100de895 Mon Sep 17 00:00:00 2001
From: dzungdo <neitdung@gmail.com>
Date: Fri, 12 Jan 2024 14:15:32 +0700
Subject: [PATCH] Move out const from module to testutil

---
 testing/simapp/test_helpers.go | 13 +++++++------
 testutil/utils.go              |  9 +++++++++
 x/multi-staking/types/utils.go |  8 --------
 3 files changed, 16 insertions(+), 14 deletions(-)
 create mode 100644 testutil/utils.go

diff --git a/testing/simapp/test_helpers.go b/testing/simapp/test_helpers.go
index 92f089d6..4c2dd863 100644
--- a/testing/simapp/test_helpers.go
+++ b/testing/simapp/test_helpers.go
@@ -9,6 +9,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/realio-tech/multi-staking-module/testutil"
 	multistakingtypes "github.com/realio-tech/multi-staking-module/x/multi-staking/types"
 	"github.com/stretchr/testify/require"
 	abci "github.com/tendermint/tendermint/abci/types"
@@ -87,8 +88,8 @@ func Setup(isCheckTx bool) *SimApp {
 	balance := banktypes.Balance{
 		Address: acc.GetAddress().String(),
 		Coins: sdk.NewCoins(
-			sdk.NewCoin(multistakingtypes.BaseDenom, sdk.NewInt(100000000000000)),
-			sdk.NewCoin(multistakingtypes.GovDenom, sdk.NewInt(100000000000000)),
+			sdk.NewCoin(testutil.MultistakingDenomA, sdk.NewInt(100000000000000)),
+			sdk.NewCoin(testutil.MultistakingDenomB, sdk.NewInt(100000000000000)),
 		),
 	}
 
@@ -138,11 +139,11 @@ func genesisStateWithValSet(app *SimApp, genesisState GenesisState,
 
 	// set multi staking genesis state
 	baseInfo := multistakingtypes.MultiStakingCoinInfo{
-		Denom:      multistakingtypes.BaseDenom,
+		Denom:      testutil.MultistakingDenomA,
 		BondWeight: sdk.OneDec(),
 	}
 	govInfo := multistakingtypes.MultiStakingCoinInfo{
-		Denom:      multistakingtypes.GovDenom,
+		Denom:      testutil.MultistakingDenomB,
 		BondWeight: sdk.MustNewDecFromStr("0.5"),
 	}
 	coinInfos := []multistakingtypes.MultiStakingCoinInfo{baseInfo, govInfo}
@@ -155,9 +156,9 @@ func genesisStateWithValSet(app *SimApp, genesisState GenesisState,
 
 	bondAmt := sdk.DefaultPowerReduction
 	for i, val := range valSet.Validators {
-		valDenom := multistakingtypes.BaseDenom
+		valDenom := testutil.MultistakingDenomA
 		if i%2 == 1 {
-			valDenom = multistakingtypes.GovDenom
+			valDenom = testutil.MultistakingDenomB
 		}
 		validatorCoins = append(validatorCoins, multistakingtypes.ValidatorMultiStakingCoin{
 			ValAddr:   sdk.ValAddress(val.Address).String(),
diff --git a/testutil/utils.go b/testutil/utils.go
new file mode 100644
index 00000000..f4fe1846
--- /dev/null
+++ b/testutil/utils.go
@@ -0,0 +1,9 @@
+package testutil
+
+const (
+	// MultistakingDenomA defines the multi staking denomination A
+	MultistakingDenomA = "ario"
+
+	// MultistakingDenomB defines the multi staking denomination B
+	MultistakingDenomB = "arst"
+)
diff --git a/x/multi-staking/types/utils.go b/x/multi-staking/types/utils.go
index a9abbc11..289a44de 100644
--- a/x/multi-staking/types/utils.go
+++ b/x/multi-staking/types/utils.go
@@ -4,14 +4,6 @@ import (
 	sdk "github.com/cosmos/cosmos-sdk/types"
 )
 
-const (
-	// BaseDenom defines the base denomination
-	BaseDenom = "ario"
-
-	// GovDenom defines the governance denomination
-	GovDenom = "arst"
-)
-
 func AccAddrAndValAddrFromStrings(accAddrString string, valAddrStraing string) (sdk.AccAddress, sdk.ValAddress, error) {
 	accAddr, err := sdk.AccAddressFromBech32(accAddrString)
 	if err != nil {