Add title to blog index page and image to newsletter #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
force-pushed
the
blog-title
branch
from
4a37d13 to
56486e8
Compare
ericholscher
changed the title
|
Gonna merge this so it goes out with the newsletter, but post-merge review should be fine here. |
agjohnson
reviewed
Feb 2, 2024
| @@ -53,7 +53,7 @@ | |||
|
|
|||
| <div class="ui divider"></div> | |||
|
|
|||
| <img class="ui big rounded centered image" src="{{ article.image or '/images/posts/default.svg' }}" alt="{{ article.image_credit }}"> | |||
| <img class="ui big rounded centered image" src="{{ article.image or '/images/posts/default.svg' }}" alt="{{ article.image }}"> | |||
There was a problem hiding this comment.
Looks like the alt was replaced with the image URL. I think this was correct before, no?
There was a problem hiding this comment.
Yeah, the issue comes from using HTML in the image_credit, which isn't valid in an HTML attribute. I would use striptags or escape the HTML instead of replacing with the URL.
With striptags:
Edit: added in #253
agjohnson
added a commit
that referenced
this pull request
Feb 2, 2024
PR #252 dropped the alt text to support HTML in the image credits, but a more accessible fix here is just strip the HTML from the image credits when using the credits in the attribute.
ericholscher
pushed a commit
that referenced
this pull request
Feb 2, 2024
PR #252 dropped the alt text to support HTML in the image credits, but a more accessible fix here is just strip the HTML from the image credits when using the credits in the attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://read-the-docs-website--252.com.readthedocs.build/