-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version warning banner not showing up #11869
Comments
I think I have similar issue, maybe it is the same: the theme is not showing up in the RTD generated documentation . This is how it should be https://diracprogram.org/doc/master/ And this is RTD, no theme https://diracprogram-documentation.readthedocs.io/en/latest/ ( from https://readthedocs.org/projects/diracprogram-documentation/builds/26681172/ ) There is no warning in the log concerning the sphinx_rdt_theme, https://readthedocs.org/api/v2/build/26681172.txt . Please help, what can be wrong ? |
https://diracprogram.org/doc/master/ isn't being served by RTD, so the version warning and other integrations won't work, they work only on projects hosted on RTD.
If you see the resulted html view-source:https://diracprogram-documentation.readthedocs.io/en/latest/, there is only one CSS file included https://diracprogram-documentation.readthedocs.io/en/latest/_static/theme-custom.css, you should be able to replicate that same behavior if you build the docs outside RTD. So, doesn't look related to this problem. |
@RemDelaporteMathurin it seems like there is a conflict introduced by pydata-theme. If I block the pydata-theme CSS file, I see our notificaiton. What is happening is there is some CSS rule that is being applied too generally: The Our web component does use these class names though, so this selector matches and hides our element. We're moving away from using class names entirely because of false matches like this, but we also can't stop host DOM CSS from altering display of our web components. The pydata-theme should use tighter selectors with more specificity to avoid side effects like this. @miroi Your issue looks unrelated as far as I can tell. |
I'm reopening this as discussed in #7809
Details
Expected Result
On our generated docs we expect to see the version warning banner appearing for old version or non-stable versions.
Actual Result
The banners don't appear.
We also see the problem in https://h-transport-materials.readthedocs.io/en/latest/
The text was updated successfully, but these errors were encountered: