Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: better title and discord embed #88

Closed
wants to merge 1 commit into from
Closed

imp: better title and discord embed #88

wants to merge 1 commit into from

Conversation

Mesteery
Copy link
Collaborator

No description provided.

@Julien00859
Copy link
Member

Can you provide a screenshot of the discord integration before and after ?

@Mesteery
Copy link
Collaborator Author

Mesteery commented Jan 31, 2021

Before :
image
After :
image

I think it will be better without the "Read The Docs" in gray at the top (og:site_name).

@Julien00859
Copy link
Member

Mouais c'est naze, ça ajoute rien d'intéressant, tu as lu #85 ?

@Mesteery
Copy link
Collaborator Author

Mesteery commented Jan 31, 2021

Oui j'ai lu.
Pour un bout du code dans la description je suis pas spécialement d'accord.
Il n'y a pas que Discord qui utilise la meta description pour ces embeds, donc si un embed était affiché sur un autre plateforme, le code avec le markdown ne serait pas forcément supporté.
De plus, il faut prendre 2-3 lignes, tout en vérifiant que cela n'excède pas les 2000 caractères.
Et il faut aussi protéger contre les attaques XSS (deja fait par le template).
Mais aussi, s'il y a du markdown dans le snippet, cela casserait le markdown qui mettra le code ;

<meta name=description content="```<ext>\n<code>\n```">

<meta name=description content="```js\n'I am better than Python';\n```">

<meta name=description content="```md\n```Problem 😕```\n```">

@Mesteery Mesteery added suggestion Suggestion de fonctionnalité ou d'amélioration and removed suggestion Suggestion de fonctionnalité ou d'amélioration labels Feb 1, 2021
@Mesteery Mesteery linked an issue Feb 1, 2021 that may be closed by this pull request
@Mesteery Mesteery marked this pull request as draft February 14, 2021 13:54
@Mesteery Mesteery closed this Nov 27, 2021
@Julien00859 Julien00859 deleted the better-embed branch September 10, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meilleure intégration discord du lien
2 participants