Add 3 new views for RAs basing on "genre" of "source" of RAs #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
view05_RA_source_G07.csv includes all the RAs when the source has a Genre G07 (SF); view05_RA_source_G44.csv includes all the RAs when the source has a Genre G44.
the source of the genre has a genre_type 'Fiction'
Basing on genre or genre_type, 3 new views for all RAs with only autobiographical source, with only SF source, with only 'fiction' source, separately.
|
So, do you want to merge this now? |
Hi Lena, thanks for asking. Now I figured it out I have one more file type to modify andI can merge it later myself. Then just leave it to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three csv tables were added. They are:
Reading acts whose source in Act table has a genre value "G44"(autobiography);
Reading acts whose source in Act table has a genre value "G07"(science fiction);
Reading acts whose source in Act table has a genre which has "genre_type" as "fiction".
GitHub Action workflow was modified accordingly to be able to generate new views whenever the data in ReadAct is updated.
There three views will be used in the "ReadAct" page of the ReadChina website.
The GitHub Action run after merging might fail for this PR due to a bug in frictionless (see #527 ). They are working on it and it is expected that the auto-run of GitHub Action next week will be passed.
And another PR should be open after this PR to update the views in the datapackage.json file accordingly.