Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readings in the king of children #428

Closed
wants to merge 5 commits into from

Conversation

mira-gruenwald
Copy link
Collaborator

Readings in _The King of Children_by A Cheng

Please indicate issues related to this PR (if any)

See #427 .

Checklist

  • The title line explains what these changes do
  • All my changes are marked in the last_modfied column
  • The PR has no merge conflicts
  • Travis checks are passing

@mira-gruenwald
Copy link
Collaborator Author

Checks failed because I added AWxxxx as source in Person.csv. It's the protagonist in Red Lantern, so the source is Artwork not PrimarySource. Should I change the schema then?

@duncdrum
Copy link
Member

duncdrum commented Jun 4, 2020

@mira-gruenwald not necessary, as the refactoring i did for 1.0 already takes care of that. All schemas have been updated already and put into this repo, i ll take a look when i refactor the 2.0 branch in a little while

@duncdrum
Copy link
Member

@mira-gruenwald sorry i lost track of this, are these acts part of the the last PR or do they still need to get merged separately.

@mira-gruenwald
Copy link
Collaborator Author

Hi @duncdrum , they still need to get merged

@duncdrum duncdrum self-assigned this Jul 29, 2021
@duncdrum
Copy link
Member

To keep track the only error:

data/Person.csv is INVALID
1. source_1: pattern. Row: 1432,18. AW00084
2. source_1: pattern. Row: 1433,18. AW00084
1. birthyear: inconsistent_values. Column: 10
2. source_1: inconsistent_values. Column: 18
3. source_2: inconsistent_values. Column: 20
4. page_2: inconsistent_values. Column: 21

@duncdrum duncdrum mentioned this pull request Jul 29, 2021
4 tasks
@duncdrum
Copy link
Member

Superseded by #474

@duncdrum duncdrum closed this Aug 10, 2021
@duncdrum duncdrum deleted the readings-in-The-King-of-Children branch August 11, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants