Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Person name: 孙子 should be "Sunzi" instead of "Zi Sun" #530

Open
whalekeykeeper opened this issue Jun 19, 2023 · 0 comments
Open

Person name: 孙子 should be "Sunzi" instead of "Zi Sun" #530

whalekeykeeper opened this issue Jun 19, 2023 · 0 comments
Assignees
@whalekeykeeper

Comments

@whalekeykeeper
Copy link
Contributor

孙子 is given the family_name Sun and first_name Zi. Thus, his name in English will be Zi Sun.
However, 孔子 is treated as Kongzi.

Suggestion: 孙子 in English should be Sunzi
@whalekeykeeper whalekeykeeper self-assigned this Jun 20, 2023
whalekeykeeper added a commit that referenced this issue Jul 7, 2023
@whalekeykeeper
Update Person.csv
3e6250e 
see #530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whalekeykeeper whalekeykeeper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whalekeykeeper