Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP Bug] Disabling Encryption succeeds silently #200

Closed
ghost opened this issue May 22, 2019 · 1 comment
Closed

[PHP Bug] Disabling Encryption succeeds silently #200

ghost opened this issue May 22, 2019 · 1 comment

Comments

@ghost
Copy link

ghost commented May 22, 2019

This is the ReactPHP tracking issue for the PHP bug https://bugs.php.net/bug.php?id=78051 and is related to #199 (#199 (comment)).

Bug summary:

When you try to disable encryption on a stream socket (with encryption enabled),
the operation succeeds, however PHP reports this as failure.

Both the server and client are able to read and write
successfully after disabling encryption.
@ghost ghost mentioned this issue May 22, 2019
@clue
Copy link
Member

clue commented Oct 28, 2019

@CharlotteDunois Thanks for sharing your finding and letting us know 👍 I agree this is something that we need to be aware of and this is something that should be fixed upstream in PHP itself 👍

The way I understand this, this does not currently affect our APIs because we do not support disabling encryption. Additionally, I'm not sure this is even on the roadmap and I would even argue this is rarely used in practice.

I believe this has been answered, so I'm closing this for now. Please come back with more details if this problem persists and we can still discuss and/or reopen this 👍

@clue clue closed this as completed Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant