Skip to content
This repository has been archived by the owner on Jul 19, 2019. It is now read-only.

render mode is unconfigurable #54

Open
fumihwh opened this issue Aug 7, 2015 · 5 comments
Open

render mode is unconfigurable #54

fumihwh opened this issue Aug 7, 2015 · 5 comments

Comments

@fumihwh
Copy link

fumihwh commented Aug 7, 2015

I have read the issue 17 and test source.
#17
https://github.com/reactjs/react-art/blob/master/src/__tests__/ReactART-test.js#L55-L59

And I think there is no way to change the render mode.
In ReactART.js, there is requiring the art/modes/fast, that decide the mode used in ReactART.
@sebmarkbage You said that is already configurable and already do this in the unit test.
Actually L56-L59 in ReactART-test.js do nothing about ReactART Object.

I think you can just delete the L14 in ReactART.js, and let us choose the mode freely.

@webxl
Copy link

webxl commented Sep 9, 2015

I agree with @fumihwh. The unit test has access to the dependency's API directly, whereas any application built on top of this doesn't. Mode needs to be exposed in ReactART, along with the available modes (e.g. ReactART.AvailableModes.SVG). And ideally you could change the mode with a component property.

@varghesep
Copy link

@fumihwh + I'm also looking for a solution.

@shripadk
Copy link

shripadk commented Oct 3, 2015

+1. Would be great if the mode is configureable.

@zemlanin
Copy link

+1

@andru
Copy link

andru commented Jan 1, 2016

+1 Also looking to have this configurable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants