Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete code no longer needed in new service provider #85

Open
JustinPihony opened this issue Nov 6, 2020 · 0 comments · May be fixed by #86
Open

Remove obsolete code no longer needed in new service provider #85

JustinPihony opened this issue Nov 6, 2020 · 0 comments · May be fixed by #86

Comments

@JustinPihony
Copy link
Collaborator

HTTPS redirects are now enabled, so the HTTPS check can be removed from the filter. Per James:

We had this because Heroku didn't offer any redirects at the routing layer, but in my opinion HTTPS redirection is a routing concern that the app should not deal with if it can avoid it. This would also mean you can remove the special handling of the healthcheck in that filter. Likewise, if we can remove the reactivemanifesto.org to www.reactivemanifesto.org redirect, that would be ideal, then I guess we can remove the filter altogether.

@sebastian-alfers sebastian-alfers linked a pull request Nov 11, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant