Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive.Streams.TCK targets .NET CLR only #45

Open
Horusiath opened this issue Oct 21, 2018 · 7 comments
Open

Reactive.Streams.TCK targets .NET CLR only #45

Horusiath opened this issue Oct 21, 2018 · 7 comments

Comments

@Horusiath
Copy link

At this point Reactive.Streams target only .NET CLR 4.5+. The test suite supports neither .net core nor .net standard. The project should be updated and released to target .net standard 2.0.

@akarnokd
Copy link
Contributor

I've run into this issue too when trying to update my old Framework test code to .NET Core 3.

@viktorklang
Copy link
Contributor

Easiest is probably to open a PR?

Ping @reactive-streams/dotnet-contributors

@akarnokd
Copy link
Contributor

I would have, but I have no idea how such things are done in the .NET world. I rely on Visual Studio new project and whatever that sets up. Build target, deployments, NuGet packaging - magic.

@viktorklang
Copy link
Contributor

viktorklang commented Nov 15, 2019 via email

@akarnokd
Copy link
Contributor

I kept googling the error messages and managed to add new target: #46. The generated nupkg files look fine to me.

@Aaronontheweb
Copy link

We'd love to update these packages to target .NET Core instead of .NET Framework.

@akarnokd at the moment @cconstantin and I are the members of the Reactive.Streams organization on NuGet where all of the official packages live. We originally created that org because we were approached by some folks from the Reactive Foundation (Ryland Degnan) who wanted push access to these packages but I don't think Ryland ever accepted my invite.

I'd like to do the following things:

  1. Add some of the members of the Reactive.Streams / Reactive Foundation team to the Reactive.Streams NuGet organization so you can push updates;
  2. Contribute some CI for automatically running the test suite and doing new releases - we use some standardized Azure DevOps template for doing this but we can do Github Actions if that would be easier; and
  3. Push an update to the TCK with Upgrade to NUnit 3.12, Add NetCore 3.0 variant #46 merged in and the new license updates reflected on Github.

Who are the right people for step 1?

@Arkatufus Arkatufus mentioned this issue Aug 21, 2020
@viktorklang
Copy link
Contributor

@Aaronontheweb Not sure, but feel free to invite me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants