From a6573f1b07a3bedc725293dc25f88ccf3a84987c Mon Sep 17 00:00:00 2001 From: Irfanwani Date: Sun, 10 Nov 2024 15:07:13 +0530 Subject: [PATCH 1/2] remove duplicate definitions of startcall and displayincomingcall as react native is thorwing error with the latest version --- .../java/io/wazo/callkeep/RNCallKeepModule.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java b/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java index b8bc889e..fe12e294 100644 --- a/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java +++ b/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java @@ -428,10 +428,10 @@ public void unregisterEvents() { this.hasListeners = false; } - @ReactMethod - public void displayIncomingCall(String uuid, String number, String callerName) { - this.displayIncomingCall(uuid, number, callerName, false, null); - } + // @ReactMethod + // public void displayIncomingCall(String uuid, String number, String callerName) { + // this.displayIncomingCall(uuid, number, callerName, false, null); + // } @ReactMethod public void displayIncomingCall(String uuid, String number, String callerName, boolean hasVideo) { @@ -477,10 +477,10 @@ public void answerIncomingCall(String uuid) { conn.onAnswer(); } - @ReactMethod - public void startCall(String uuid, String number, String callerName) { - this.startCall(uuid, number, callerName, false, null); - } + // @ReactMethod + // public void startCall(String uuid, String number, String callerName) { + // this.startCall(uuid, number, callerName, false, null); + // } @ReactMethod public void startCall(String uuid, String number, String callerName, boolean hasVideo) { From f11b28e4bacdb9ca0d25c7b74fc3941d53adbd09 Mon Sep 17 00:00:00 2001 From: Irfan Wani Date: Wed, 29 Jan 2025 19:18:46 +0530 Subject: [PATCH 2/2] remove comments Code cleaning, nothing special --- .../main/java/io/wazo/callkeep/RNCallKeepModule.java | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java b/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java index fe12e294..e05f9e2b 100644 --- a/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java +++ b/android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java @@ -428,11 +428,6 @@ public void unregisterEvents() { this.hasListeners = false; } - // @ReactMethod - // public void displayIncomingCall(String uuid, String number, String callerName) { - // this.displayIncomingCall(uuid, number, callerName, false, null); - // } - @ReactMethod public void displayIncomingCall(String uuid, String number, String callerName, boolean hasVideo) { this.displayIncomingCall(uuid, number, callerName, hasVideo, null); @@ -477,11 +472,6 @@ public void answerIncomingCall(String uuid) { conn.onAnswer(); } - // @ReactMethod - // public void startCall(String uuid, String number, String callerName) { - // this.startCall(uuid, number, callerName, false, null); - // } - @ReactMethod public void startCall(String uuid, String number, String callerName, boolean hasVideo) { this.startCall(uuid, number, callerName, hasVideo, null);