Skip to content

Commit 9a5468d

Browse files
committed
chore: fix logic
1 parent 56bd4f5 commit 9a5468d

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

src/Handles/Handle.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,10 @@ export interface HandleProps
2323
onOffsetChange: (value: number | 'min' | 'max', valueIndex: number) => void;
2424
onFocus: (e: React.FocusEvent<HTMLDivElement>, index: number) => void;
2525
onMouseEnter: (e: React.MouseEvent<HTMLDivElement>, index: number) => void;
26-
render?: (origin: React.ReactElement<HandleProps>, props: RenderProps) => React.ReactElement;
26+
render?: (
27+
origin: React.ReactElement<React.HTMLAttributes<HTMLDivElement>>,
28+
props: RenderProps,
29+
) => React.ReactElement;
2730
onChangeComplete?: () => void;
2831
}
2932

src/Handles/index.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,13 @@ const Handles = React.forwardRef<HandlesRef, HandlesProps>((props, ref) => {
9797
<Handle
9898
key="a11y"
9999
{...handleProps}
100-
aria-hidden
101100
value={values[activeIndex]}
102101
valueIndex={0}
103102
dragging={draggingIndex !== -1}
104103
render={activeHandleRender}
105104
style={{ pointerEvents: 'none' }}
105+
tabIndex={-1}
106+
aria-hidden
106107
/>
107108
)}
108109
</>

src/Slider.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,12 +291,13 @@ const Slider = React.forwardRef<SliderRef, SliderProps<number | number[]>>((prop
291291
};
292292

293293
const finishChange = () => {
294-
onAfterChange?.(getTriggerValue(rawValuesRef.current));
294+
const finishValue = getTriggerValue(rawValuesRef.current);
295+
onAfterChange?.(finishValue);
295296
warning(
296297
!onAfterChange,
297298
'[rc-slider] `onAfterChange` is deprecated. Please use `onChangeComplete` instead.',
298299
);
299-
onChangeComplete?.(getTriggerValue(rawValuesRef.current));
300+
onChangeComplete?.(finishValue);
300301
};
301302

302303
const [draggingIndex, draggingValue, cacheValues, onStartDrag] = useDrag(

src/hooks/useDrag.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ function useDrag(
3232
const mouseMoveEventRef = React.useRef<(event: MouseEvent) => void>(null);
3333
const mouseUpEventRef = React.useRef<(event: MouseEvent) => void>(null);
3434

35-
React.useEffect(() => {
35+
React.useLayoutEffect(() => {
3636
if (draggingIndex === -1) {
3737
setCacheValues(rawValues);
3838
}

0 commit comments

Comments
 (0)