Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePicker doesn't support tabIndex #48059

Closed
wang-yikai opened this issue Mar 24, 2024 · 6 comments · Fixed by react-component/picker#779
Closed

DatePicker doesn't support tabIndex #48059

wang-yikai opened this issue Mar 24, 2024 · 6 comments · Fixed by react-component/picker#779
Assignees
@zombieJ
Labels
⌨️ Accessibility Inactive

Comments

@wang-yikai
Copy link

wang-yikai commented Mar 24, 2024 •
edited
Loading

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Pass tabIndex={-1} and see that DatePicker can still be focused.

What is expected?

DatePicker should get focused in the right order and DatePicker with -1 tabIndex shouldn't get focused.

What is actually happening?

Press tab on the keyboard and see that DatePicker gets focused in the wrong order and DatePicker with -1 tabIndex still gets focused.

Environment Info
antd 5.15.2
React 18
System MacOS
Browser Chrome

This was resolved in #23918 but not for AntD v5.
@afc163
Copy link
Member

afc163 commented Mar 25, 2024

图片

@afc163 afc163 added the 🤔 Need Reproduce We cannot reproduce your problem label Mar 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hello @wang-yikai. Please provide a online reproduction by forking codesandbox of [email protected] or [email protected], or provide a minimal GitHub repository. Issues labeled by Need Reproduce will be closed if no activities in 3 days.

你好 @wang-yikai，我们需要你提供一个在线的重现实例以便于我们帮你排查问题。你可以通过点击这里创建一个 [email protected] 或 [email protected] 的 codesandbox，或者提供一个最小化的 GitHub 仓库。3 天内未跟进此 issue 将会被自动关闭。

什么是最小化重现，为什么这是必需的？

@wang-yikai
Copy link
Author

@afc163 I made the sandbox public, my apologies!

@afc163 afc163 removed 🤔 Need Reproduce We cannot reproduce your problem unconfirmed labels Mar 25, 2024
@wang-yikai wang-yikai mentioned this issue Mar 25, 2024
Merged
@wang-yikai
Copy link
Author

I've created react-component/picker#779 to fix this issue.

@wang-yikai
Copy link
Author

@zombieJ Any progress with merging react-component/picker#779?

@nathanlao
Copy link
Contributor

@afc163 Does the PR above resolve the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zombieJ zombieJ

Labels
⌨️ Accessibility Inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add tabIndex support wang-yikai/rc-picker
4 participants
@afc163 @zombieJ @wang-yikai @nathanlao