feat: support max length #313

hengkx · 2021-04-07T02:41:52Z

close #311

vercel · 2021-04-07T02:41:55Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/input-number/BSk7kabHAJHYj8812gYYqvizA2iD
✅ Preview: https://input-number-git-maxlength-react-component.vercel.app

yoyo837 · 2021-04-07T02:43:37Z

个人拙见，input-number基本属于 maxlength无关的组件。

codecov · 2021-04-07T02:44:36Z

Codecov Report

Merging #313 (427d533) into master (99cb077) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 427d533 differs from pull request most recent head 76d2bf8. Consider uploading reports for the commit 76d2bf8 to get more accurate results

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
+ Coverage   97.25%   97.27%   +0.01%     
==========================================
  Files           8        8              
  Lines         401      403       +2     
  Branches      106      109       +3     
==========================================
+ Hits          390      392       +2     
  Misses         11       11

Impacted Files	Coverage Δ
src/InputNumber.tsx	`98.19% <100.00%> (+0.02%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99cb077...76d2bf8. Read the comment docs.

hengkx · 2021-04-07T02:45:35Z

产品需求就是输入到最大后用户不能再输入了

yoyo837 · 2021-04-07T02:48:03Z

我的意思是input-number应该min,max控制是不是就足够了？

另外如果支持两位小数，手动输入时，maxlength会不会对100.00 和 100 造成影响？

afc163 · 2021-04-07T02:49:10Z

透传原生 maxLength 够用了吧。

hengkx · 2021-04-07T02:49:44Z

我的意思是input-number应该min,max控制是不是就足够了？

另外如果支持两位小数，手动输入时，maxlength会不会对100.00 和 100 造成影响？

min,max 是输入到最大后可以继续输入，鼠标离开后会重置成最大，maxlength 会对 100.00 和 100 造成影响

hengkx · 2021-04-07T02:50:41Z

我的意思是input-number应该min,max控制是不是就足够了？
另外如果支持两位小数，手动输入时，maxlength会不会对100.00 和 100 造成影响？

min,max 是输入到最大后可以继续输入，鼠标离开后会重置成最大，maxlength 会对 100.00 和 100 造成影响

因为这些属性都是用户自己设置的，他可以根据他的实际情况以及需求来做设置

yoyo837 · 2021-04-07T02:50:42Z

所以maxlength和min、max有冲突，按什么逻辑处理？

hengkx · 2021-04-07T02:52:19Z

透传原生 maxLength 够用了吧。

好像是有问题的，我们之前的代码是重写了onInput 方法，这边的改动导致该方法不兼容了

yoyo837 · 2021-04-07T02:53:08Z

反过来，部分用户会不会理解为遵循maxlength 而min max用户根据他的实际情况以及需求来做设置呢？

感觉会造成很多Q&A issue。

hengkx · 2021-04-07T02:53:42Z

所以maxlength和min、max有冲突，按什么逻辑处理？

现在的改动是超出maxlength后直接截取字符串然后在走后面的逻辑

zombieJ · 2021-04-08T02:44:58Z

src/InputNumber.tsx

      let inputStr = e.target.value;
+      if (maxLength) {


来个测试用例哈~

yoyo837 · 2021-04-08T02:48:06Z

src/InputNumber.tsx

      let inputStr = e.target.value;
+      if (maxLength) {


Suggested change

if (maxLength) {

if (maxLength >= 0) {

这样会不会好些？

不太对哦，是不是大于0 就行了等于没有任何意义吧

不太对哦，是不是大于0 就行了等于没有任何意义吧

主要目的是为了判断为数字

Co-authored-by: Amumu <[email protected]>

yoyo837 · 2021-04-08T02:57:41Z

tests/input.test.tsx

@@ -80,6 +80,11 @@ describe('InputNumber.Input', () => {
    expect(wrapper.getInputValue()).toEqual('');
  });

+  it('max length', () => {


再加一个0的？

tests/input.test.tsx

zombieJ · 2021-04-13T03:36:31Z

tests/input.test.tsx

+  });
+
+  it('control max length', () => {
+    const wrapper = mount(<InputNumber value={9} maxLength={3} />);


value={1234}，它的长度需要超过 maxLength，且结果是 1234 不会被裁剪。

value={1234} max 是1 那它的值还是1234?

嗯，受控时总是以受控提供的为准。

https://ant.design/components/input-number-cn/#%E4%B8%BA%E4%BD%95%E5%8F%97%E6%8E%A7%E6%A8%A1%E5%BC%8F%E4%B8%8B%EF%BC%8Cvalue-%E5%8F%AF%E4%BB%A5%E8%B6%85%E5%87%BA-min-%E5%92%8C-max-%E8%8C%83%E5%9B%B4%EF%BC%9F

zombieJ · 2021-04-13T04:02:10Z

LGTM，先等一下这个 #316。好了后发个 minor。

afc163 · 2021-04-13T05:09:13Z

为啥不是直接透传 maxLength 给原生 input 元素呢？

zombieJ · 2021-04-13T05:27:09Z

为啥不是直接透传 maxLength 给原生 input 元素呢？

format 可以改输入内容，用户输入不一定是最终展示值。

afc163 · 2021-04-13T05:48:45Z

那原生 maxLength 也够用了吧，设置不超过 format 后的长度就行。

AngelPP52 · 2021-04-15T11:13:34Z

我也有一样的想法，但老兄这里要把键盘事件/step事件也考虑上吧？

feat: support max length

373b294

hengkx requested a review from zombieJ April 7, 2021 02:41

hengkx mentioned this pull request Apr 7, 2021

通过 formatter 格式化数字的InputNumber 输入0，输入框自动填入0.01的问题 ant-design/ant-design#30034

Closed

1 task

zombieJ reviewed Apr 8, 2021

View reviewed changes

src/InputNumber.tsx Outdated

let inputStr = e.target.value;

if (maxLength) {

Copy link

Member

zombieJ Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

来个测试用例哈~

yoyo837 reviewed Apr 8, 2021

View reviewed changes

Update input.test.tsx

3afcbfb

vercel bot deployed to Preview April 8, 2021 02:50 View deployment

hengkx and others added 2 commits April 8, 2021 10:51

Update src/InputNumber.tsx

7f479e1

Co-authored-by: Amumu <[email protected]>

Update InputNumber.tsx

971b777

vercel bot deployed to Preview April 8, 2021 02:57 View deployment

yoyo837 reviewed Apr 8, 2021

View reviewed changes

Update input.test.tsx

7e5c598

vercel bot deployed to Preview April 8, 2021 03:00 View deployment

zombieJ reviewed Apr 8, 2021

View reviewed changes

tests/input.test.tsx Show resolved Hide resolved

Update input.test.tsx

aa6cea0

vercel bot deployed to Preview April 8, 2021 04:51 View deployment

hengkx requested a review from zombieJ April 12, 2021 05:50

zombieJ reviewed Apr 13, 2021

View reviewed changes

Update input.test.tsx

76d2bf8

vercel bot deployed to Preview April 13, 2021 03:41 View deployment

hengkx requested a review from zombieJ April 13, 2021 03:41

hengkx closed this Sep 10, 2021

hengkx deleted the maxLength branch September 10, 2021 09:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support max length #313

feat: support max length #313

hengkx commented Apr 7, 2021

vercel bot commented Apr 7, 2021 •

edited

Loading

yoyo837 commented Apr 7, 2021

codecov bot commented Apr 7, 2021 •

edited

Loading

hengkx commented Apr 7, 2021

yoyo837 commented Apr 7, 2021

afc163 commented Apr 7, 2021

hengkx commented Apr 7, 2021

hengkx commented Apr 7, 2021

yoyo837 commented Apr 7, 2021

hengkx commented Apr 7, 2021 •

edited

Loading

yoyo837 commented Apr 7, 2021

hengkx commented Apr 7, 2021

zombieJ Apr 8, 2021

yoyo837 Apr 8, 2021

hengkx Apr 8, 2021

yoyo837 Apr 8, 2021

yoyo837 Apr 8, 2021

zombieJ Apr 13, 2021

hengkx Apr 13, 2021 •

edited

Loading

zombieJ Apr 13, 2021

zombieJ commented Apr 13, 2021

afc163 commented Apr 13, 2021

zombieJ commented Apr 13, 2021

afc163 commented Apr 13, 2021

AngelPP52 commented Apr 15, 2021

feat: support max length #313

feat: support max length #313

Conversation

hengkx commented Apr 7, 2021

vercel bot commented Apr 7, 2021 • edited Loading

yoyo837 commented Apr 7, 2021

codecov bot commented Apr 7, 2021 • edited Loading

Codecov Report

hengkx commented Apr 7, 2021

yoyo837 commented Apr 7, 2021

afc163 commented Apr 7, 2021

hengkx commented Apr 7, 2021

hengkx commented Apr 7, 2021

yoyo837 commented Apr 7, 2021

hengkx commented Apr 7, 2021 • edited Loading

yoyo837 commented Apr 7, 2021

hengkx commented Apr 7, 2021

zombieJ Apr 8, 2021

Choose a reason for hiding this comment

yoyo837 Apr 8, 2021

Choose a reason for hiding this comment

hengkx Apr 8, 2021

Choose a reason for hiding this comment

yoyo837 Apr 8, 2021

Choose a reason for hiding this comment

yoyo837 Apr 8, 2021

Choose a reason for hiding this comment

zombieJ Apr 13, 2021

Choose a reason for hiding this comment

hengkx Apr 13, 2021 • edited Loading

Choose a reason for hiding this comment

zombieJ Apr 13, 2021

Choose a reason for hiding this comment

zombieJ commented Apr 13, 2021

afc163 commented Apr 13, 2021

zombieJ commented Apr 13, 2021

afc163 commented Apr 13, 2021

AngelPP52 commented Apr 15, 2021

vercel bot commented Apr 7, 2021 •

edited

Loading

codecov bot commented Apr 7, 2021 •

edited

Loading

hengkx commented Apr 7, 2021 •

edited

Loading

hengkx Apr 13, 2021 •

edited

Loading