Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute names #10

Open
linhsolar opened this issue Sep 12, 2023 · 4 comments
Open

Fix attribute names #10

linhsolar opened this issue Sep 12, 2023 · 4 comments
Assignees

Comments

@linhsolar
Copy link
Contributor

linhsolar commented Sep 12, 2023

Pls. use well-defined attribute names in qoa language, no space in the attribute name,
e.g. (dataquality.py)

 results = {}
 results["Total Errors"] = error_df.to_numpy().flatten().sum()
 results["Error Ratio"] = 100*error_df/total_count
@minhtribk12
Copy link
Contributor

Attribute name Updated

@linhsolar
Copy link
Contributor Author

still the problem exists:
if isinstance(image,PIL.JpegImagePlugin.JpegImageFile) or isinstance(image,PIL.Image.Image):
# qoaLogger.debug(dir(image)
quality["Image Width"] = image.width
quality["Image Height"] = image.height
quality["Image Size"] = image.size
quality["Color Mode"] = image.mode
quality["Color Channel"] = len(image.getbands())

@minhtribk12
Copy link
Contributor

Spaces removed

@linhsolar linhsolar reopened this Sep 17, 2023
@linhsolar
Copy link
Contributor Author

this issue has not be completely solved: check mlquality.py.

I suggest to keep the same way whenever we introduce a new attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants