Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1 - Issue Fix - TvSettings #47

Open
akhilbhas opened this issue Oct 9, 2024 · 0 comments · May be fixed by #48
Open

L1 - Issue Fix - TvSettings #47

akhilbhas opened this issue Oct 9, 2024 · 0 comments · May be fixed by #48
Assignees
Labels
bug Something isn't working L1 related issues

Comments

@akhilbhas
Copy link
Contributor

akhilbhas commented Oct 9, 2024

  1. In Tc's test_l1_tvSettings_negative_SetCurrentComponentLuma,
    VTS is expecting invalid value, but the current parameter passed to HAL API by VTS is valid, so VTS Testcase is getting failed.

Current code:

            if((tvDataComponentColor_t) componentColor !=(tvDataComponentColor_t) i)
            {
                bModeMatched = false;
                break;            
             }

Correct code


            if((tvDataComponentColor_t) componentColor !=(tvDataComponentColor_t) i)
            {
                bModeMatched = true;
                break;            
             }

Verify in all tests.

  1. In test_l1_tvSettings_positive_GetMaxGainValue, and test_l1_tvSettings_negative_GetMaxGainValue
    update logic to verify range
    maxGain = GetMaxGainValue();
    UT_ASSERT_TRUE( (maxGain >= (2^10)) && ( maxGain <= (2^31)-1) );
@akhilbhas akhilbhas added the bug Something isn't working label Oct 9, 2024
akhilbhas added a commit that referenced this issue Oct 10, 2024
* Range value updated
* corrected the valid value check
@akhilbhas akhilbhas linked a pull request Oct 10, 2024 that will close this issue
@akhilbhas akhilbhas linked a pull request Oct 10, 2024 that will close this issue
akhilbhas added a commit that referenced this issue Oct 10, 2024
* Removed unwanted checks present in the L1 code.
@akhilbhas akhilbhas changed the title L1 - Issue Fix L1 - Issue Fix - TvSettings Oct 11, 2024
akhilbhas added a commit that referenced this issue Oct 16, 2024
* correcting typo
akhilbhas added a commit that referenced this issue Oct 18, 2024
* test_l1_tvSettings_positive_GetTVSupportedPictureModes memory
  allocation issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working L1 related issues
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants