Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare tests for backward compatibility #15

Open
skodapetr opened this issue Jan 10, 2020 · 0 comments
Open

Prepare tests for backward compatibility #15

skodapetr opened this issue Jan 10, 2020 · 0 comments

Comments

@skodapetr
Copy link
Contributor

We should have tests that will ensure backward compatibility of p2rank.
This is important for further development as contributors may not know why are certain things in the code.

For example:

    static String correctResidueCode(String residueCode) {
        //MSE is only found as a molecular replacement for MET
        //'non-standard', genetically encoded
        if (residueCode=="MSE")
            residueCode = "MET"
        else if (residueCode=="MEN")  // N-METHYL ASPARAGINE
            residueCode = "ASP"

        return residueCode
    }

is this specific for certain dataset/protein, etc...

In the ideal scenario we should have also test for every non-standard/invalid data p2rank can consume and internally sanitize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant